darion-yaphet commented on PR #3612: URL: https://github.com/apache/brpc/pull/3612#issuecomment-6186482606
Thanks, moving protobuf ahead of the generic dependency prefixes looks right. Two small things before merging: 1. `src/` now comes after protobuf. If protobuf sits in a shared prefix that also has an installed brpc, the installed `butil/`/`brpc/` headers will shadow the in-tree ones. 2. The test targets aren't covered yet. `test/CMakeLists.txt:29` adds `GPERFTOOLS_INCLUDE_DIR` directly to `brpc_test_config`, so `/opt/homebrew/include` is still searched before protobuf when building unit tests. macOS CI doesn't build the tests, so it won't catch this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
