darion-yaphet commented on PR #3612: URL: https://github.com/apache/brpc/pull/3612#issuecomment-6437138387
Thanks for the update. The two points from my earlier comment look addressed for this PR's scope: 1. `brpOn the `src/` vs Protobuf shared-prefix case, I agree with @wasphin that it is a separate, limited concern and does not need to block this change. One CI nits before merge: License Check fails because `test/protobuf_include_order/generic_include/google/protobuf/stubs/common.h` has no valid license header. The poison `#define` can stay; please add the usual Apache header above it. With that, LGTM from my side on the CMake ordering fix and the regression test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
