chenBright opened a new pull request, #3705: URL: https://github.com/apache/brpc/pull/3705
### What problem does this PR solve? Issue Number: resolve Problem Summary: `FDTest.mod_closed_fd` assumes that creating a new pipe reuses the descriptor numbers of the previously closed pipe. Concurrent fd activity can invalidate this assumption and cause intermittent [CI](https://github.com/apache/brpc/actions/runs/41588287607/job/125758788458) failures. ``` [ RUN ] FDTest.mod_closed_fd bthread_fd_unittest.cpp:391: Failure Expected equality of these values: fd[0] Which is: 72 new_fd[0] Which is: 70 [ FAILED ] FDTest.mod_closed_fd (0 ms) ``` ### What is changed and the side effects? Changed: - Use `dup2()` to atomically replace the registered descriptor while the test still owns it. - Check `EBADF` with `-1` to avoid racing with descriptor reuse. - Manage the epoll descriptor and both pipes with `fd_guard`, including cleanup on assertion failures. Side effects: - Performance effects: - Breaking backward compatibility: --- ### Check List: - Please make sure your changes are compilable. - When providing us with a new feature, it is best to add related tests. - Please follow [Contributor Covenant Code of Conduct](https://github.com/apache/brpc/blob/master/CODE_OF_CONDUCT.md). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
