On Wed, 2020-07-22 at 11:25 +0200, Jürg Billeter wrote:
[...]
> However, if there is no suitable replacement in time for 2.0, it may
> make sense to move bst-artifact-server to a separate repository to make
> it clear we don't want to maintain bst-artifact-server long term as
> part of BuildStream core. In that separate repository I wouldn't mind
> keeping the ReferenceStorage server part for bst 1.x compatibility if
> there is interest.
>
> And if there is an interested maintainer we could have bst-artifact-
> server in a separate repository even if there is a suitable replacement
> in time for 2.0. This could be done at any time after the merge of
> !1978. Prerequisite is #1371.
>
> Based on the above my plan would be to keep ReferenceStorage server
> support in master for now, however, it will be dropped from the
> BuildStream core repository before 2.0. Either dropped completely or
> moved to a separate repository.
>
> Does this sound like a reasonable way forward to everyone?
This makes general sense to me.
I see a potential use case in the medium term for bst-artifact-server
even after BuildStream 2 is released: it may be a hard(ish) requirement
for users in a transitional period, for instance; I'm pretty sure we
will see a period of at least 1 year where freedesktop-sdk will need to
support both BuildStream 1 and BuildStream 2 (master on bst2 and bst1
still required until stable is no longer supported).
It seem unattractive to migrate to BuildStream 2 if you need to
maintain 2 completely separate infrastructures for artifact storage
during the transitional period where you will be needing both.
Given that this mostly means just splitting out some code into a
separate repository (and copy/pasting in the relevant installation
documentation into the new repository's README.md), I think it would be
wise to consider this separate repository creation as a blocker to
removing the bst-1 client support in current master.
Delaying this "split" is also a better strategy I think: the longer we
delay splitting out this bst-artifact-server with dual client support,
the less likely we are to need to patch this artifact server outside of
BuildStream.
Cheers,
-Tristan
