On Wed, 2024-03-13 at 14:22 +0100, Abderrahim Kitouni wrote: > So after discussing this with Tristan, we reached the conclusion it > would be better to drop the check, but keep the rules in the > documentation.
It seems to me that marking URLs in `configure()` is still required for the mirroring logic to work properly (`__do_fetch()` calling `__clone_for_uri()`). If that's true, completely dropping the check would be a risk of having source plugins with silently broken mirroring if they don't mark the URL. As I understand it, the crucial part of marking URLs is to get the alias (if any). This means that it would be acceptable to allow calling `translate_url()` with a suffix of a marked URL. My suggestion would be to add an optional `suffix: str` parameter to `translate_url()`. This would perform the existing check on the base URL but then translate the concatenation of URL + suffix. This concatenation would then also be passed to source mirror plugins in the future. Does this make sense or am I missing something? Cheers, Jürg
