Le mer. 13 mars 2024 à 16:49, Jürg Billeter <[email protected]> a écrit :
> It seems to me that marking URLs in `configure()` is still required for
> the mirroring logic to work properly (`__do_fetch()` calling
> `__clone_for_uri()`). If that's true, completely dropping the check
> would be a risk of having source plugins with silently broken mirroring
> if they don't mark the URL.

Right, this is the risk we're taking.

> As I understand it, the crucial part of marking URLs is to get the
> alias (if any). This means that it would be acceptable to allow calling
> `translate_url()` with a suffix of a marked URL.
>
> My suggestion would be to add an optional `suffix: str` parameter to
> `translate_url()`. This would perform the existing check on the base
> URL but then translate the concatenation of URL + suffix. This
> concatenation would then also be passed to source mirror plugins in the
> future.
>
> Does this make sense or am I missing something?

I think this could work. I'll try to implement it.

Thanks,

Abderrahim

Reply via email to