The intention of Stamatis's proposal is to just add a new state in JIRA workflow, to help clarify that the pull request is opened and under review. It does help monitor the working progress, especially for a release manager, IMHO. But I don't think having an assigned reviewer is necessary.
- Haisheng ------------------------------------------------------------------ 发件人：Danny Chan<yuzhao....@gmail.com> 日 期：2019年07月24日 09:50:05 收件人：<dev@calcite.apache.org> 主 题：Re: Add "IN REVIEW" state in JIRA Workflow Thanks Michael, just to make things more clear, I’m not saying only committers can review the code, I’m talking about the “IN REVIEW” tag, if we mark the PR in review, it would somehow discourage other people who has willingness on the code review. So I think It is not a good idea to let anyone change the tag state. Actually I just added a “Request Review” tag on the GitHub page, because there are often some delay of code reviewing these days. Best, Danny Chan 在 2019年7月23日 +0800 PM9:45，Michael Mior <mm...@apache.org>，写道： > I would strongly oppose limiting who can review code. Only committers > can actually commit code, so we already have a mechanism for limiting > what code makes it in. I haven't seen anyone give a really bad code > review and if that does happen, I would rather address it on a case by > case basis instead of discouraging people from reviewing code. > > On the topic of making it easier to review PRs, what would be helpful > for me is if people could assign PRs to themselves on GitHub when they > agree to review them. It makes it a lot easier to find ones which are > languishing when I have a bit of spare time to review PRs. I think > this is a relatively easy process since it's just one extra click if > you're viewing the PR on GitHub. > > -- > Michael Mior > mm...@apache.org > > Le lun. 15 juil. 2019 à 22:19, Danny Chan <yuzhao....@gmail.com> a écrit : > > > > Sounds like a good idea if this state can only be seen by committers/PMC, > > because we should keep the quality of code reviewing, we should make some > > limit on who can review the code, as far as I know, many contributors are > > not that familiar with our code, and usually a good review comes from > > committers or even only from Julian ！ > > > > Best, > > Danny Chan > > 在 2019年7月15日 +0800 PM11:47，Stamatis Zampetakis <zabe...@gmail.com>，写道： > > > Hello, > > > > > > I was thinking that it would be helpful if we had an additional JIRA state > > > stating that the ticket is under ongoing review. > > > > > > It would help to better monitor progress and provide more insights towards > > > the release. > > > > > > Having an assigned reviewer (most often a committer) would mean that this > > > person is going to help resolving the ticket for the next release (or find > > > somebody else to delegate this task). That doesn't mean that other people > > > should not participate in the discussion, however if things block he/she > > > should be the first person to take action. > > > > > > What do you think? > > > > > > If there are not any objections, I will create an INFRA ticket. > > > > > > Best, > > > Stamatis
