Personally, I would opt for a more permissive build. Unexpected line endings is kind of subjective. I guess there are people who use Windows and they still have their editors configured to use LF endings.
Moreover, checking other opensource projects it is kind of rare to release source code in multiple formats with different line endings. I didn't attempt to build these projects but I would be surprised if the build fails depending on the OS. Indeed in some cases these might lead to test failures or other weird behavior but these should not happen very often. On Tue, Dec 24, 2019 at 3:44 PM Vladimir Sitnikov < sitnikov.vladi...@gmail.com> wrote: > Stamatis> do we have another option so that the build does not fail on > Windows? > > It boils down to a question: should the build fail if the source files > contain unexpected line endings? > > Suppose someone uses Windows, and they create test_sql_plan.txt file with > wrong line endings (==LF). > Should the build fail? > > Suppose someone uses Linux and they create a file with CRLF line endings. > Should the build fail? > > Of course, Git will normalize the line endings at commit time, and > everybody who pulls that commit would get the normalized file. > > However, if the local file is different from what Git expects, it might > result in hard to understand conditions like > unexpected test failures or inability to reproduce CI test failure. > > Vladimir >
