I also agree that some commit messages are not that clear. But, I what to make cleat that: keeping the commit message understandable is the duty of the code reviewer, if the commit message is problematic, how could the code be merged.
It is so hard to re-think what these commits really do because long time passes and there are 260+ commits, how could a release manager to keep every commit message “readable”. So I would just ignore that ~ Best, Danny Chan 在 2020年3月4日 +0800 AM7:20，Stamatis Zampetakis <zabe...@gmail.com>，写道： > Ubuntu 18.04.4 LTS, jdk 1.8.0_212, Gradle wrapper > > * Checked signatures and checksums OK > * Build and run unit tests (./gradlew clean build) on git repo and staged > sources OK > It is worth mentioning that the build passed with the 3rd attempt. In the > first attempts the build was stuck while performing style checking. I > assume there is somewhere a race condition coming from the fact that I have > many cores available on my machine (Intel Core i7-8850H) and the > multi-threaded Gradle build. > * Run slow tests on git repo (./gradlew testSlow) OK > By the way on my machine the slow tests run in 7 minutes which is quite > impressive and I think comes mostly from Vladimir's effort of enabling > parallel execution and other improvements. > * Checked diff between git commit and staged sources OK > Small differences in the license structure but I brought this before and > there does not seem to be a problem. > * Went over the release note OK > I outline at the end of this email a few minor remarks regarding the > release notes. > > A big thanks to Danny for being the release manager and for also fixing the > various problems that we encountered in the previous release candidates! > Another big thanks to all those who tested this, and the previous RCs, > against downstream projects. Ideally, we should be able to detect > regressions before the RC phase but in any case it is better late than > ever. > > I cannot give a +1 vote due to CALCITE-3839 and given that in the past we > shooted down release candidates for less obvious reasons. I think we are > lowering a bit our standards biased from the fact that we didn't have a > release for quite some time. Anyways, I don't see CALCITE-3839 as a > critical bug so I am fine with having another release rather soon. > > 0 (binding) > > Best, > Stamatis > > * The release date should be updated after the to reflect the actual > release date. > * Should we really mention that the release has been tested with Apache > Druid version 0.14.0-incubating? Did anybody run the tests against Druid? I > tried to do it a few weeks ago but I had a few problems with setting up the > VM in calcite-test-dataset. > * I was under the impression that the Hint API would be experimental for > some time but it seems in the end it was decided not to do so. I am not > against it but I am just mentioning it to be sure that we are all in the > same page. > > Below a few comments (nitpicking) for the following commits (entries of the > release note). > I am not saying that we should go and change everything now but as Julian > mentioned in another email we should try to be more pedantic with the > commit messages since they become our release notes (and should be > understandable by end-users). > > [CALCITE-3437] ElasticSearch adapter. Support MatchQuery in elasticsearch > (Shlok Srivastava) > > The use of period could be avoided: Support MatchQuery in ElasticSearch > adapter > [CALCITE-3434] ElasticSearch schema with pathPrefix (Jeffery Zhang) > > The message is not self-contained. Not sure if it is a bug or feature, or > in general what has changed. > Add hsqldb data sets (scott, foodmart and chinook) to SQLLine's path > > Should we capitalize HSQLDB? > [CALCITE-3606] Derive target table column list by mistake when convert > TableModify to Sql string (JinXing) > > The message is not clear. > [CALCITE-3630] Improve ReduceExpressionsRule > > The message is too general. What is the improvement? > [CALCITE-3246] NullPointerException while deserializing udf operator (Wang > Yanlin). > > We do not use periods at the first line of the commit message nor at the > summary of the JIRA. > [CALCITE-3546] Improve EnumerableDefaults nested loop join Provide a new > implementation of nested loop join that, unlike the existing one, does not > require to build the complete result as a list before returning it. > Instead, it iterates through the outer and inner enumerables and returns > the results step by step. > > Very long entry. Seems like a copy-edit problem or bug in the script > generating the release notes. > [CALCITE-3285] EnumerableMergeJoin should support non-equi join condions > (Jin Xing) > > This change has been reverted (and the JIRA has been reopened) so it > shouldn't appear in the release notes. > [CALCITE-3479] Stack overflow error thrown when running join queryi > (Xiening Dai) > > Typo queryi -> query and a bit general description. Every join query > leads to stack overflow? > [CALCITE-3376] VolcanoPlanner CannotPlanException: best rel is null even > though there is an option with non-infinite cost Problem solved via > CALCITE-2018, just add a unit test for this specific scenario > > Very long entry. Seems like a copy-edit problem or bug in the script > generating the release notes. > [CALCITE-3383] Plural time units > > The message is not self-contained. Cannot understand what happend without > looking in the diff or in the JIRA issue. > [CALCITE-3389] Test may fail if HashSet iterates in different order > (contextshuffling) > > Which test? > [CALCITE-3381] When using BigQuery dialect, Rel2SQL converter converts SQL > types to BigQuery types (Rui Wang) > > The message is not clear. Is it a bug or an enhancement? Rel2SQL > converter -> `RelToSqlConverter` > Simplify reproducerFor3457 test > > Typo? > Site: Update homepage of Stamatis Zampetakis > Site: Add Haisheng Yuan as PMC > > Should we keep in the release note these kind of updates to the Website? > > On Tue, Mar 3, 2020 at 11:23 AM Ruben Q L <rube...@gmail.com> wrote: > > > +1 (non binding) > > Local Calcite build with tests (Windows10 + JDK8): OK > > Calcite-based application test suite: OK > > > > > > > > Le mar. 3 mars 2020 à 11:11, Enrico Olivelli <eolive...@gmail.com> a > > écrit : > > > > > +1 (non binding) > > > Run tests locally (on Mac + JDK13) > > > Run tests of HerdDB and a bunch of know applications that are using > > HerdDB > > > > > > Thank you Danny > > > > > > Enrico > > > > > > Il giorno mar 3 mar 2020 alle ore 11:06 Feng Zhu > > > <wellfeng...@gmail.com> ha scritto: > > > > > > > > Hi Danny, thanks for your continuous effort! > > > > > > > > +1 (non-binding) > > > > > > > > - Build and Test (./gradlew build) - OK > > > > - Checked Release Notes - OK > > > > - Checked README - OK > > > > - Validate gpg signature - OK > > > > Environment 1: Windows 7, JDK 1.8.0_121 > > > > Environment 2: Mac OS X 10.15.1, JDK 1.8.0_231_b11 > > > > > > > > Bests, > > > > Feng > > > > > > > > Danny Chan <yuzhao....@gmail.com> 于2020年3月2日周一 下午9:28写道： > > > > > > > > > Hi all, > > > > > > > > > > I have created a build for Apache Calcite 1.22.0, release > > > > > candidate 3. > > > > > > > > > > Thanks to everyone who has contributed to this release. > > > > > > > > > > You can read the release notes here: > > > > > > > > https://github.com/apache/calcite/blob/v1.22.0-rc3/site/_docs/history.md > > > > > > > > > > The commit to be voted upon: > > > > > > > > > > > > > > > https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=537b8dbb4b58c61b6c573eb07a51b8d38896a1ff > > > > > > > > > > Its hash is 537b8dbb4b58c61b6c573eb07a51b8d38896a1ff > > > > > > > > > > Tag: > > > > > https://github.com/apache/calcite/tree/v1.22.0-rc3 > > > > > > > > > > The artifacts to be voted on are located here: > > > > > > > > https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.22.0-rc3 > > > > > (revision 38350) > > > > > > > > > > The hashes of the artifacts are as follows: > > > > > > > > > > > > > > > a7dface824287756fcc66f6f075286975e409e7ea9a0af97ad973f90bc2832250c09e0477bc571bd78f6ee3721883cce76cada9a3e9601e1dd497fb02679647f > > > > > *apache-calcite-1.22.0-src.tar.gz > > > > > > > > > > A staged Maven repository is available for review at: > > > > > > > > > > > > > > > https://repository.apache.org/content/repositories/orgapachecalcite-1080/org/apache/calcite/ > > > > > > > > > > Release artifacts are signed with the following key: > > > > > https://people.apache.org/keys/committer/danny0405.asc > > > > > https://www.apache.org/dist/calcite/KEYS > > > > > > > > > > N.B. > > > > > To create the jars and test Apache Calcite: "./gradlew build". > > > > > > > > > > If you do not have a Java environment available, you can run the > > tests > > > > > using docker. To do so, install docker and docker-compose, then run > > > > > "docker-compose run test" from the root of the directory. > > > > > > > > > > Please vote on releasing this package as Apache Calcite 1.22.0. > > > > > > > > > > The vote is open for the next 72 hours and passes if a majority of at > > > > > least three +1 PMC votes are cast. > > > > > > > > > > [ ] +1 Release this package as Apache Calcite 1.22.0 > > > > > [ ] 0 I don't feel strongly about it, but I'm okay with the release > > > > > [ ] -1 Do not release this package because... > > > > > > > > > > > > > > > Here is my vote: > > > > > > > > > > +1 (binding) > > > > > > > > > > Best, > > > > > Danny Chan > > > > > > > > > >
