Hi Vladimir, Thanks for bringing this up. In general, I believe annotations for nullability are beneficial for code readability and reasoning. However, after reading the PR, I am having the same feelings as Nikolay.
Intuitively, the "@Nullable" annotation does not provide much information, and it does not make the code more readable (IMO). In addition, is it possible to break the PR into a number of small ones? A large PR is difficult to review and difficult to merge. Best, Liya Fan On Thu, Nov 19, 2020 at 5:38 AM Julian Hyde <jh...@apache.org> wrote: > Regardless of how it got there, the change to > 2020-10-06-release-1.26.0.md is currently in the change that you are > proposing to commit (see the top of > https://patch-diff.githubusercontent.com/raw/apache/calcite/pull/2268.patch > ), > and it shouldn't be. > > Julian > > On Wed, Nov 18, 2020 at 1:12 PM Vladimir Sitnikov > <sitnikov.vladi...@gmail.com> wrote: > > > > Julian>Please remove the change you made to > > Julian>site/_posts/2020-10-06-release-1.26.0.md in this PR > > > > Julian, I rebase checkerframework branch from time to time, and the > commit > > you mention was on master branch. > > > > I'm all ears if you have questions or suggestions regarding the checker > > framework. > > > > Vladimir >
