Hi, regarding CALCITE-2489: https://github.com/apache/calcite-avatica/pull/138
I have improved the PR description with a more detailed walkthrough of the changes, hoping it will make it smoother to review. If you can think of anything I can do to help more please let me know. Best regards, Alessandro On Sat, 20 Feb 2021 at 21:13, Alessandro Solimando < alessandro.solima...@gmail.com> wrote: > Hi Francis, all, > I saw Stamatis' comment under > https://github.com/apache/calcite-avatica/pull/105 (CALCITE-3163) asking > to add unit-tests to avoid regressions, I have added them and opened a > complementing PR which you can find here > https://github.com/apache/calcite-avatica/pull/139. > > Best regards, > Alessandro > > > On Fri, 19 Feb 2021 at 08:30, Francis Chuang <francischu...@apache.org> > wrote: > >> Hi Alessandro, >> >> Thanks! That would be really awesome! >> >> Francis >> >> On 19/02/2021 5:47 pm, Alessandro Solimando wrote: >> > Hi, >> > I can review and open a new PR for >> > https://github.com/apache/calcite-avatica/pull/105 (CALCITE-3163) if a >> > committer can then help me merging it. >> > >> > Best regards, >> > Alessandro >> > >> > Il Ven 19 Feb 2021, 00:45 Julian Hyde <jh...@apache.org> ha scritto: >> > >> >> I'll take PR 121, [CALCITE-3881]. >> >> >> >> On Thu, Feb 18, 2021 at 2:19 PM Francis Chuang < >> francischu...@apache.org> >> >> wrote: >> >>> >> >>> A quick update on the release progress for 1.18.0: >> >>> - Waiting for CALCITE-2489: >> >>> https://github.com/apache/calcite-avatica/pull/138 >> >>> >> >>> There are a few smaller PRs that could be potentially carried: >> >>> - https://github.com/apache/calcite-avatica/pull/105 >> >>> - https://github.com/apache/calcite-avatica/pull/121 >> >>> - https://github.com/apache/calcite-avatica/pull/110 >> >>> - https://github.com/apache/calcite-avatica/pull/106 >> >>> >> >>> If anyone is interested in taking over any of the above PRs, please >> open >> >>> a new PR, and let me know so I can close out the old one. >> >>> >> >>> Francis >> >>> >> >>> On 17/02/2021 6:27 am, Julian Hyde wrote: >> >>>> I use my PR #135 for testing stuff using the CI infrastructure. It >> >>>> does not need to go into 1.18 (or any release). >> >>>> >> >>>> On Tue, Feb 16, 2021 at 6:59 AM Josh Elser <els...@apache.org> >> wrote: >> >>>>> >> >>>>> No, I wouldn't wait around for #132. When I left this off, I was >> >>>>> debugging some JVM internals to understand why stuff didn't work :) >> >>>>> >> >>>>> Thanks for asking! >> >>>>> >> >>>>> I'll try to find some time to help on the other PR's you mentioned. >> >>>>> >> >>>>> On 2/15/21 4:54 PM, Francis Chuang wrote: >> >>>>>> Hey Everyone, >> >>>>>> >> >>>>>> I am planning to make rc0 available for voting in the next few >> days. >> >>>>>> >> >>>>>> I think #129 is pretty much ready for merging. Danny, can you >> please >> >>>>>> take a look? >> >>>>>> - https://github.com/apache/calcite-avatica/pull/129 >> >>>>>> >> >>>>>> Julian and Josh, do you guys think you will be able to get your PRs >> >> into >> >>>>>> this release? >> >>>>>> >> >>>>>> - https://github.com/apache/calcite-avatica/pull/135 >> >>>>>> - https://github.com/apache/calcite-avatica/pull/132 >> >>>>>> >> >>>>>> Francis >> >>>>>> >> >>>>>> On 3/02/2021 12:50 pm, Francis Chuang wrote: >> >>>>>>> Hey everyone, >> >>>>>>> >> >>>>>>> It's been around 7 months since the last Avatica release. There >> has >> >>>>>>> been some push to get 1.18.0 out before the Calcite 1.27.0 >> release, >> >> so >> >>>>>>> that the fixes in 1.18.0 can make it into the Calcite release. >> >>>>>>> >> >>>>>>> I saw a few open PRs on Github that could be potentially merged >> for >> >>>>>>> this release: >> >>>>>>> - https://github.com/apache/calcite-avatica/pull/135 >> >>>>>>> - https://github.com/apache/calcite-avatica/pull/132 >> >>>>>>> - https://github.com/apache/calcite-avatica/pull/129 <- this one >> is >> >>>>>>> pretty much ready to merge except for the commit message >> >>>>>>> - https://github.com/apache/calcite-avatica/pull/115 <- it would >> be >> >>>>>>> nice if someone could carry this one, I think this one is almost >> >> there >> >>>>>>> >> >>>>>>> Are there any other PRs to merge or issues to look at? >> >>>>>>> >> >>>>>>> There hasn't been a whole lot of commits since the last release, >> so >> >> I >> >>>>>>> think this release should be pretty straight forward. It would be >> >> much >> >>>>>>> appreciated if the community can have a look at those PRs I have >> >>>>>>> highlighted. >> >>>>>>> >> >>>>>>> Francis >> >> >> > >> >
