Hey Alessandro,
Thanks so much for reviewing CALCITE-3401. The tests on your rebased
branch look good.
Can you open a new PR with your rebased version? The commit message
should also be updated to the correct format:
[CALCITE-3401] Assume empty keystore passwords by default (Istvan Toth,
Alessandro Solimando)
Once that's done, I'll merge it into master for this release.
Francis
On 5/02/2021 5:10 am, Alessandro Solimando wrote:
Hi Francis,
I had a look at https://github.com/apache/calcite-avatica/pull/115, LGTM, I
haven't done a review on the PR itself as I have nothing I'd change, if you
think my approval can help I will mark it as such.
I noticed that the PR has conflicts with master, I rebased it and run all
tests locally and via github actions (tests
<https://github.com/asolimando/calcite-avatica/actions/runs/534598842>
and gradle
validate
<https://github.com/asolimando/calcite-avatica/actions/runs/534598840>),
it's all good. Since the PR is from another user, I have rebased in a
branch in my own fork (
https://github.com/asolimando/calcite-avatica/tree/CALCITE-3401-rebased), I
have never pushed to an open PR from another user, maybe I could have done
(or could still do) that.
Anyway, since I am not a committer this is the farest I can go, but if
there is anything else I can do, don't hesitate to let me know.
Best regards,
Alessandro
On Wed, 3 Feb 2021 at 02:50, Francis Chuang <francischu...@apache.org>
wrote:
Hey everyone,
It's been around 7 months since the last Avatica release. There has been
some push to get 1.18.0 out before the Calcite 1.27.0 release, so that
the fixes in 1.18.0 can make it into the Calcite release.
I saw a few open PRs on Github that could be potentially merged for this
release:
- https://github.com/apache/calcite-avatica/pull/135
- https://github.com/apache/calcite-avatica/pull/132
- https://github.com/apache/calcite-avatica/pull/129 <- this one is
pretty much ready to merge except for the commit message
- https://github.com/apache/calcite-avatica/pull/115 <- it would be nice
if someone could carry this one, I think this one is almost there
Are there any other PRs to merge or issues to look at?
There hasn't been a whole lot of commits since the last release, so I
think this release should be pretty straight forward. It would be much
appreciated if the community can have a look at those PRs I have
highlighted.
Francis
