It happens to the best of us! It turns out that I've used not fewer than 5 different combinations over the years:
$ git log --author=hyde|grep Author:|sort |uniq Author: Julian Hyde <jh...@apache.org> Author: Julian Hyde <julian.h...@looker.com> Author: Julian Hyde <julianh...@gmail.com> Author: julianhyde <jh...@apache.org> Author: julianhyde <julianh...@gmail.com> These days I prefer to use my Apache email address. It makes it easy for people to link my commits, PRs, Jira cases, and email messages. Julian On Mon, Oct 17, 2022 at 7:55 AM Mou Wu <wumou.4...@outlook.com> wrote: > > Thank you, Alessandro Solimando, and Benchao Li. > > Git commit history shouldn’t be changed in any case indeed, I am just a > little nervous about the mistake I made. > > I will use my personal email in the future contributions. > > > > 2022年10月17日 19:21，Benchao Li <libenc...@apache.org> 写道： > > > > As I can see, there is no need to change the git commit history. > > > > Github allows adding multiple email addresses, you can add your company's > > email address to your Github account as well. After that, all the things > > will work fine in Github, such as that Github will know that you have > > committed to Calcite repo, and would not take you as a first-time > > contributor each time. > > > > > > Alessandro Solimando <alessandro.solima...@gmail.com> 于2022年10月17日周一 > > 17:52写道： > > > >> Hi Mou Wu, > >> over the years I have seen several contributors using their working emails > >> in the git commits, in principle I don't think there is any issue with > >> that. > >> > >> In any case, I guess it would not be possible to amend git history to > >> change the email, as this will change the sha1 for all subsequent commits > >> and cause issues to everyone. > >> > >> Best regards, > >> Alessandro > >> > >> On Mon, 17 Oct 2022 at 10:53, Mou Wu <wumou.4...@outlook.com> wrote: > >> > >>> Hello committers: > >>> > >>> I contributed two pull requests(commits: 3d39fdcee, b16df019e) in recent > >>> two mouths, I found I committed my company’s email instead of my personal > >>> email on these two commits(thanks Benchao Li, he reminded me), and I > >> should > >>> committed my personal email because my GitHub’s email is my personal > >> email. > >>> > >>> So I wonder whether it’s necessary to change the commit history on these > >>> two commits, there are any bad effects on apache/calcite repo using a > >>> incorrect email on commit history? > >> > > > > > > -- > > > > Best, > > Benchao Li >
