+1 This is a good idea and reduces the burden on committers to approve
the workflows.
On 29/03/2023 12:37 am, Benchao Li wrote:
I'm +1 for changing it back.
I was also thinking about starting a discussion about this before, but I
didn't know how to achieve it. Thanks Julian for sharing this with us.
Julian Hyde <jhyde.apa...@gmail.com> 于2023年3月28日周二 20:57写道：
(Forwarding from the Druid list for discussion.)
Julian
Begin forwarded message:
From: Gian Merlino <g...@apache.org>
Date: March 28, 2023 at 1:24:42 AM CDT
To: d...@druid.apache.org
Subject: CI requiring approval for external contributors
Reply-To: d...@druid.apache.org
Recently, ASF GitHub repos had their defaults for GitHub Actions
changed to
"always require approval for external contributors". In Slack, Karan
pointed out that Airflow has recently submitted a ticket to have that
changed back: https://issues.apache.org/jira/browse/INFRA-24200. IMO, we
should do the same. I don't think we have a problem with fake PRs, but we
can always improve our responsiveness to contributors from outside the
project! Every little bit helps, including running CI automatically.
If others have opinions on this, let me know. I'd like to raise our own
ticket to change our default.
Gian
