Thanks everyone for the feedback. The change is now merged!
On Wed, Apr 19, 2023 at 4:59 PM Dan Zou <zoud...@163.com> wrote: > > +1, it would reduce a lot of noise. > > Best, > Dan Zou > > > > > > > 2023年4月19日 19:37，Benchao Li <libenc...@apache.org> 写道： > > > > +1, > > > > One thing that may affect current workflow is sometimes I only watch the > > Jira, and will get notified from the PR notification. If we are going to > > disable it, I need to watch the PR too to get the notification for cases > > that I'm interested in both the Jira discussion and PR comments. But that > > won't be a big problem for me. > > > > Michael Mior <mm...@apache.org> 于2023年4月19日周三 18:43写道： > > > >> +1 from me as well > >> > >> On Wed, Apr 19, 2023, 04:19 Stamatis Zampetakis <zabe...@gmail.com> wrote: > >> > >>> Hello, > >>> > >>> Everything that happens in a GitHub PR creates a worklog entry under > >>> the respective JIRA ticket. > >>> For every worklog entry we receive a notification from j...@apache.org > >>> when we are watching an issue. The worklog entry and email > >>> notification usually appear messy. > >>> > >>> Moreover, if we are watching the GitHub PR we are going to get a > >>> notification from notificati...@github.com which has the same content > >>> with the JIRA worklog entry and is much more readable. > >>> > >>> Finally, the PR notification is also going to > >>> comm...@calcite.apache.org so those who are subscribed to that list > >>> will get the same notification three times. > >>> > >>> Personally, I never read the JIRA worklog notifications and I largely > >>> prefer those from notificati...@github.com. > >>> > >>> How do you feel about disabling the worklog entries in JIRA coming > >>> from GitHub PRs? > >>> > >>> For archiving purposes, the notifications already go to commits@ so we > >>> don't lose anything from disabling the worklog entries. On the > >>> contrary, I find that this would reduce the noise and redundancy on > >>> our inboxes. > >>> > >>> Concretely this is what I have in mind in terms of change: > >>> https://github.com/apache/calcite/pull/3166 > >>> > >>> Best, > >>> Stamatis > >>> > >> > > > > > > -- > > > > Best, > > Benchao Li >
