I don't think it's a bad idea but I'm also not sure whether it's worth the time and effort of deciding what functions should be grouped together, etc. Seeing as how methods in that class are mostly (always?) called via reflection, I think having them in one place is helpful in ensuring consistent code style/patterns. Test classes in Calcite, for instance, vary in thoroughness, documentation, formatting, etc, but individual tests in the same class rarely vary from one another. That's just from a maintenance/consistency perspective, if there's some performance issues or otherwise that I'm neglecting then maybe it is worth the attention.
Tanner On Mon, Jan 29, 2024 at 8:02 PM Forward Xu <[email protected]> wrote: > hi, > I noticed that the code file of the SqlFunctions.java class is getting > larger and larger and the functions are increasing. I think some functions > can be broken down into different function classes to slim down > SqlFunctions. For example: json functions use JsonFunctions, and only > SqlFunctions retain Function name reference. > > What do you think? > > Best, > ForwardXu >
