Ubuntu 22.04.5 LTS, jdk1.8.0_421, Gradle wrapper, Gradle 8.7
* Checked signatures and checksums OK
* Checked diff between repo and artifacts OK
* Checked README, NOTICE, LICENSE OK
* All source files have ASF headers OK (grep -RiL "Licensed to the
Apache Software Foundation")
* No unexpected binary files OK (find . -type f -exec file {} \; |
grep -v text)
* Checked LICENSE, NOTICE, for calcite-core-1.40.0.jar in nexus OK
* Built from git tag and run tests (./gradlew build) KO
* Built from source artifacts and run tests (gradle build) KO
As Francis reported already
org.apache.calcite.test.LintTest.html#testMailmapFile fails which
makes the build fail. Although it is not a code production issue I
still consider this as a blocker.
If we accept the release we are basically accepting the main branch to
be broken on the release commit. I don't think we would ever merge
anything in the main branch after knowing that it fails the build.
For calcite devs it may be straightforward that the test failure is
not a serious problem but it may not be the case for the general
public.
Lastly, there may be external CI/CD pipelines that use the release
sources to build their own Calcite binaries and if the suggested build
command fails it could cause issues and extra work on downstream
consumers.
-1 zabetak (PMC)
Best,
Stamatis
On Fri, May 23, 2025 at 1:44 PM Francis Chuang <[email protected]> wrote:
>
> Thanks for being RM for this release, Alessandro.
>
> My vote is: +1 francischuang (PMC)
>
> The lint test for the mailmap file fails for me, but as this is just the
> mailmap file and not Calcite itself, I am still inclined to +1 this
> release and fix the out of order entry after this release:
>
> FAILURE 0.0sec, org.apache.calcite.test.LintTest > testMailmapFile()
> org.opentest4j.AssertionFailedError: line 'Chuxin Chen
> <[email protected]>' is out of order
> at
> app//org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:38)
> at app//org.junit.jupiter.api.Assertions.fail(Assertions.java:135)
> at
> app//org.apache.calcite.test.LintTest.testMailmapFile(LintTest.java:528)
>
> 16.4sec, org.apache.calcite.materialize.LatticeSuggesterTest >
> testUnion()
> 0.1sec, 2 completed, 0 failed, 0 skipped,
> org.apache.calcite.test.LogicalProjectDigestTest
> 14.4sec, org.apache.calcite.rel.logical.ToLogicalConverterTest
> > testWindow()
> 5.2sec,
> org.apache.calcite.test.JdbcFrontJdbcBackLinqMiddleTest > testWhere2()
> 0.4sec, 1 completed, 0 failed, 0 skipped,
> org.apache.calcite.test.LinqFrontJdbcBackTest
> 4.7sec, org.apache.calcite.test.JdbcFrontJdbcBackTest >
> testWhere2()
> WARNING 4.7sec, 7 completed, 0 failed, 1 skipped,
> org.apache.calcite.test.JdbcFrontJdbcBackTest
> FAILURE 0.6sec, 8 completed, 1 failed, 2 skipped,
> org.apache.calcite.test.LintTest
> ...
> FAILURE 92.7sec, 12850 completed, 1 failed, 108 skipped, Gradle Test
> Run :core:test
>
> - Verified GPG signature - OK
> - Verified SHA512 - OK
> - Diffed source release and git repository - OK
> - Checked release notes on tag
> (https://github.com/apache/calcite/blob/calcite-1.40.0-rc0/site/_docs/history.md)
> - OK
> - Checked year and versions in NOTICE, README and HOWTO - OK
> - Ran tests (gradle check) - OK
> - Spot checked Nexus artifacts - OK
>
> Environment:
> Eclipse-temurin:23 docker container in WSL2 (Ubuntu 24.04.2) on Windows
> 11 24h2
>
> $ docker version
> Client:
> Version: 28.1.1
> API version: 1.49
> Go version: go1.23.8
> Git commit: 4eba377
> Built: Fri Apr 18 09:51:06 2025
> OS/Arch: linux/amd64
> Context: default
>
> Server: Docker Desktop 4.0.0 ()
> Engine:
> Version: 28.1.1
> API version: 1.49 (minimum version 1.24)
> Go version: go1.23.8
> Git commit: 01f442b
> Built: Fri Apr 18 09:52:57 2025
> OS/Arch: linux/amd64
> Experimental: false
> containerd:
> Version: 1.7.27
> GitCommit: 05044ec0a9a75232cad458027ca83437aae3f4da
> runc:
> Version: 1.2.5
> GitCommit: v1.2.5-0-g59923ef
> docker-init:
> Version: 0.19.0
> GitCommit: de40ad0
>
> $ gradle -v
>
> ------------------------------------------------------------
> Gradle 8.7
> ------------------------------------------------------------
>
> Build time: 2024-03-22 15:52:46 UTC
> Revision: 650af14d7653aa949fce5e886e685efc9cf97c10
>
> Kotlin: 1.9.22
> Groovy: 3.0.17
> Ant: Apache Ant(TM) version 1.10.13 compiled on January 4 2023
> JVM: 23.0.2 (Eclipse Adoptium 23.0.2+7)
> OS: Linux 5.15.167.4-microsoft-standard-WSL2 amd64
>
> $ java --version
> openjdk 23.0.2 2025-01-21
> OpenJDK Runtime Environment Temurin-23.0.2+7 (build 23.0.2+7)
> OpenJDK 64-Bit Server VM Temurin-23.0.2+7 (build 23.0.2+7, mixed mode,
> sharing)
>
> Francis
>
> On 23/05/2025 7:08 pm, Alessandro Solimando wrote:
> > Hi all,
> >
> > I have created a build for Apache Calcite 1.40.0, release
> > candidate 0.
> >
> > Thanks to everyone who has contributed to this release.
> >
> > You can read the release notes here:
> > https://github.com/apache/calcite/blob/calcite-1.40.0-rc0/site/_docs/history.md
> >
> > The commit to be voted upon:
> > https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=770bac04efe974af338d3f732ae197df4c4e7b14
> >
> > Its hash is 770bac04efe974af338d3f732ae197df4c4e7b14
> >
> > Tag:
> > https://github.com/apache/calcite/tree/calcite-1.40.0-rc0
> >
> > The artifacts to be voted on are located here:
> > https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.40.0-rc0
> > (revision 77071)
> >
> > The hashes of the artifacts are as follows:
> > b594e6d0c0e57d6569964f63a485c38879c4f8cff1e43a1a0a47c296495a2392099f3135a250fcad3bad8e94c32fdb02f99e84e7cf230ee619fa3576185b6bb7
> > *apache-calcite-1.40.0-src.tar.gz
> >
> > A staged Maven repository is available for review at:
> > https://repository.apache.org/content/repositories/orgapachecalcite-1246/org/apache/calcite/
> >
> > Release artifacts are signed with the following key:
> > https://people.apache.org/keys/committer/asolimando.asc
> > https://www.apache.org/dist/calcite/KEYS
> >
> > To create the jars and test Apache Calcite: "gradle build"
> > (Requires an appropriate Gradle/JDK installation.)
> >
> > Please vote on releasing this package as Apache Calcite 1.40.0.
> > Everyone is welcome to vote. Your vote should contain the line
> > 'code name (role)', where
> > * 'code' is +1, 0 or -1 as below;
> > * 'name' is your ASF id if you have one, else your real name;
> > * 'role' is 'community', 'committer' or 'PMC member'.
> >
> > [ ] +1 Release this package as Apache Calcite 1.40.0
> > [ ] 0 I don't feel strongly about it, but I'm okay with the release
> > [ ] -1 Do not release this package because...
> >
> > The vote is open for the next 72 hours (closing at
> > 2025-05-26T08:00:00Z) and passes if a majority of
> > at least three +1 votes by PMC members are cast.
> >
> > NOTES:
> > 1) I have noticed that in the release notes some entries have a wrong
> > "<\a>" instead of "</a>", but usually minor issues with release notes are
> > considered OK as they can be addressed after the release vote
> >
> > 2) LICENSE file differs from that of git, it has been discussed in [1],
> > it's not considered a blocker and CALCITE-7036 [2] has been filed to
> > improve this aspect
> >
> > Also considering these two notes, my vote is:
> >
> > +1 asolimando (PMC member)
> >
> > Alessandro Solimando (release manager)
> >
> > [1]: https://lists.apache.org/thread/hfxqnm0xc8l5nzdbsm2fon91rw94t3to
> > [2]: https://issues.apache.org/jira/browse/CALCITE-7036
> >
>
