+1 getChildExps should go away before 1.0 but let’s keep it around for the next week or so. Often clients know they are dealing with a particular RelNode type and can call Project.getProjects() or Filter.getCondition().
How to you propose to handle the use of getChildExps in RelWriterImpl? That method needs to be efficient, because it is used from computeDigest(). Julian On Dec 13, 2014, at 12:52 PM, Vladimir Sitnikov <[email protected]> wrote: > Hi, > > Please review a fix for getChildExps -> accept(RexShuttle) > > https://github.com/apache/incubator-calcite/pull/31 > > I made RexShuttle.mutate more NPE-proof since there are null values in > MultiJoin.outerJoinConditions somehow. > > -- > Regards, > Vladimir Sitnikov
