Let’s get rid of those asserts. That code is executed a lot, RelNode attributes are not added very often, and methods such as RelWriter.item(String term, Object value) help keep attributes and their values in sync.
On Dec 13, 2014, at 1:57 PM, Vladimir Sitnikov <[email protected]> wrote: >> How to you propose to handle the use of getChildExps in RelWriterImpl? > > RelWriterImpl is using getChildExps _only_ to assert that all the > RexNodes were inserted in correct order (e.g. the order of .item calls > match getChildExps). > > Is this a proper assertion at all? > > I can emulate that behavior with RexShuttle and it won't hurt > performance much since it would execute only in assert-enabled build. > However I do not feel this assertion was properly placed in the first place. > > Vladimir
