[ 
https://issues.apache.org/activemq/browse/CAMEL-1921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=56172#action_56172
 ] 

Hadrian Zbarcea commented on CAMEL-1921:
----------------------------------------

@Christian,

Excellent contribution, many thanks for sharing.

A few comments for whomever commits this patch (could be me :)).  No need to 
resubmit.

1. There is an extra dependency on camel-spring test-jar in the pom, needs to 
be removed.
2. In general when there are routes that depend on each other such as A -> B 
and B -> C, we prefer to order them in reverse order: B -> C and A -> B, 
because we want the consumer from B to be started before the producer to B.  
It's less important in your case, with a direct consumer, but in general with a 
polling consumer (such as file:) or with a timer, you risk sending messages to 
B before the consumer is started and hence lose messages.

The 2.1 release should be out in a few days and then we can put this in.



> New SMPP component
> ------------------
>
>                 Key: CAMEL-1921
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-1921
>             Project: Apache Camel
>          Issue Type: New Feature
>    Affects Versions: 1.6.1
>         Environment: All
>            Reporter: Christian Mueller
>             Fix For: 2.2.0
>
>         Attachments: camel-smpp-20091127214200.patch, camel-smpp.patch
>
>
> Provide a component for the SMPP (short message peer to peer) protocol to 
> send and receive short messages from a SMSC (short message service center).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to