[ https://issues.apache.org/activemq/browse/CAMEL-2790?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bengt Rodehav updated CAMEL-2790: --------------------------------- Attachment: FtpOperations.diff FtpsConfiguration.diff I've added diff files for the changes I've done in FtpOperations.java and FtpsConfiguration.java. Looking at the changes that Claus has made in the trunk I have the following comments: - I prefer Claus way of creating an FtpsOperations extended from FtpOperations. It is a much better way to add ftps specific connect handling. - Although I think that giving the user a lot of options to configure is a good thing, I believe that Claus solution might give the user too many options to choose from. To my understanding the following applies (I might be wrong since I'm not really an ftps expert): a) Only "PROT C" (clear text) and "PROT P" (encrypted) are applicable to ftps. b) When specifying "PROT P" one must always specify "PBSZ 0" before "PROT B". c) If "PROT C" is specified it is not normally necessary to specify "PBSZ" at all, the default setting is probably OK. I therefore think that it would be more user friendly to just specify whether a secure data channel should be used or not. If true, then "PBSZ 0" followed by "PROT P" should be sent. If false, then only "PROT C" should be sent. To give the user more options, the "execProt" and "execPbsz" options can of course still be added. However, if they are omitted then I think that the above should apply. This would make camel-ftp easier to configure. > camel-ftp - Add options to set secure protection level when using FTPS > ---------------------------------------------------------------------- > > Key: CAMEL-2790 > URL: https://issues.apache.org/activemq/browse/CAMEL-2790 > Project: Apache Camel > Issue Type: Improvement > Components: camel-ftp > Affects Versions: 2.3.0 > Reporter: Claus Ibsen > Assignee: Claus Ibsen > Fix For: 2.4.0 > > Attachments: FtpOperations.diff, FtpsConfiguration.diff > > > See nabble > http://old.nabble.com/camel-ftp-problems-with-ftps-implicit-mode-ts28777705.html > We should add options so end user can set the options he wants for > - execProt > - execPbsz -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.