[
https://issues.apache.org/jira/browse/CAMEL-3480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12979601#action_12979601
]
Dan Checkoway commented on CAMEL-3480:
--------------------------------------
Claus, looks good. All tests passed (I temporarily uncommented the @Ignore
annotations...thanks for adding those).
The only catch is that assertions need to be disabled if camel-kestrel uses
want to take advantage of ?waitTimeMs=... on a kestrel endpoint. Long story
short, spymemcached uses assertions to ensure that the key returned from
memcached (or kestrel in this case) matches the key requested. It's kinda
funky, because you request "myqueue/t=200" (where 200 is the waitTimeMs value)
from the server, and it returns "myqueue"....which is totally valid and
expected in our case. But the assertion fails. If we were talking to
memcached, that would make sense, but the "extensions" that kestrel provides
require that the returned key be slightly different than the requested key.
By default, the JVM disables assertions at runtime. So I'm not sure why
spymemcached author(s) chose to use that mechanism. Although it's convenient
that they did, because that's what lets us use spymemcached to talk to kestrel!
However...mvn test enables JVM assertions, so this needs to be added to pom.xml
to get the tests to work:
<build>
<plugins>
<plugin>
<artifactId>maven-surefire-plugin</artifactId>
<configuration>
<enableAssertions>false</enableAssertions>
</configuration>
</plugin>
</plugins>
</build>
I'll update the Kestrel page on the Camel wiki, making a NOTE about the effect
of assertions, and the requirement for assertions to be disabled for
spymemcached to work with kestrel.
> New component: Kestrel
> ----------------------
>
> Key: CAMEL-3480
> URL: https://issues.apache.org/jira/browse/CAMEL-3480
> Project: Camel
> Issue Type: New Feature
> Reporter: Dan Checkoway
> Assignee: Claus Ibsen
> Priority: Minor
> Fix For: 2.6.0
>
> Attachments: CAMEL-3480-20110110-full.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> I'm proposing that some adapted open-source code for producing to/consuming
> from Kestrel be added as an official Camel component. Currently the code
> lives here: https://github.com/dcheckoway/camel-kestrel
> Please assign this to me if you'd like me to own this.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
