[ 
https://issues.apache.org/jira/browse/CAMEL-4358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13087786#comment-13087786
 ] 

Claus Ibsen commented on CAMEL-4358:
------------------------------------

Yeah that could be a good idea.

However if we are to change the API a bit, we may consider removing the 
{{Statistic createStatistic(String name, Object owner, Statistic.UpdateMode 
updateMode);}} method from the ManagementStrategy and create the Statistics 
instances directly in the source code. I doubt any SPI need to create other 
kind of Statistic objects in a 3rd party management strategy.

Then we keep Statistic as an internal object in the org.apache.camel.management 
package.

However I am also okay for the move to spi.



> Move org.apache.camel.management.Statistic to org.apache.camel.spi.Statistic
> ----------------------------------------------------------------------------
>
>                 Key: CAMEL-4358
>                 URL: https://issues.apache.org/jira/browse/CAMEL-4358
>             Project: Camel
>          Issue Type: Improvement
>          Components: camel-core
>    Affects Versions: 2.8.0
>            Reporter: Christian Schneider
>            Assignee: Christian Schneider
>             Fix For: 2.9.0
>
>
> Currently Statistic.UpadateMode is used in 
> org.apache.camel.spi.ManagementStrategy. The problem is that Statistic is 
> located in org.apache.camel.management together with impl classes. So we have 
> a dependency from an spi package to an impl package.
> I propose to move Statistic to spi as it is an interface and needed to 
> implement a ManagementStrategy. I don“t think Statistic is used outside 
> camel-core at the moment so I would like to do the change already for camel 
> 2.9.0

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


Reply via email to