[ https://issues.apache.org/jira/browse/CAMEL-4358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13089291#comment-13089291 ]
Christian Schneider commented on CAMEL-4358: -------------------------------------------- @Claus: I was not sure about the spi package either. The annotations are clearly part of the API or SPI though. So I could also place them in org.apache.camel. Normally API means that you call something using an interface and SPI means that you implement an interface. On the other hand API is tpypically understood to be user faced while SPI is about 3rd party extension. As the annotations are typically used for components they could even fall in the 3rd party case but as said I am not really sure either. > Refactoring of management code to remove cycles and clearly separate between > API and impl > ----------------------------------------------------------------------------------------- > > Key: CAMEL-4358 > URL: https://issues.apache.org/jira/browse/CAMEL-4358 > Project: Camel > Issue Type: Improvement > Components: camel-core > Affects Versions: 2.8.0 > Reporter: Christian Schneider > Assignee: Christian Schneider > Fix For: 2.9.0 > > Attachments: CAMEL-4358-1.patch > > > Currently the management code (org.apache.camel.management.*) contains a mix > of implementation code and APIs. This leads to cycle in the management code > as well as to bigger cycles involving all of camel-core. > So I propose to do several changes: > - move interfaces and annotations that form the API to camel.spi.management. > As these are probably not used by external components or user code no > compatibility classes are created > - create new package camel.suppport for classes that implement API or SPI > classes and are expected to be extended by many impl classes. classes in > support may only access the camel API and SPI > - Move EventNotifierSupport and ServiceSupport to this package. Create > deprecate dummys in the old locations to avoid breaking older code > - Move DefaultEventFactory from management to management.event > I will post a patch shortly for review -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira