On Tue, Mar 29, 2016 at 6:21 AM, Claus Ibsen <claus.ib...@gmail.com> wrote:
> Can we flip the switch so you have to enable it on the maven modules > that you want to be an osgi bundle. I am asking because people who are > not using OSGi should really not see camel.osgi.skip=true in the > examples / camel-spring-boot-starter etc. > > They should be clean and without any osgi stuff. > > Also I would rather make it explicit that this maven module is built > as an osgi bundle if it has camel.osgi=true. > I see your point. What I'll do is make the activation rely on property value comparison rather than property presence, e.g. camel.osgi=true/false. That way, we can set camel.osgi=true on components/pom.xml, and exclude only the few components that are not OSGi by setting camel.osgi=false on their POMs. For the examples, we can set camel.osgi=false on examples/pom.xml, and only set the property to true on those examples that are meant to be bundles. Let's play with value rather than presence/absence, because once you set a property up the chain in the Maven reactor, I don't think you can unset it (or can you?). Although... Approaching it from a different angle, it may be worth to explicitly define the build plugins in each example POM. Thus we can attempt to make the example "self-contained". That would take more work, so I won't do it now, but just wanted to hear your thoughts. Cheers, *Raúl Kripalani* PMC & Committer @ Apache Ignite, Apache Camel | Integration, Big Data and Messaging Engineer http://about.me/raulkripalani | http://www.linkedin.com/in/raulkripalani Blog: raul.io | twitter: @raulvk <https://twitter.com/raulvk>
