I forgot to say awesome! Comments inline. Sent from my iPhone
> On Dec 13, 2018, at 1:27 AM, Zoran Regvart <zo...@regvart.com> wrote: > > Hi David, > thanks for the feedback, I really appreciate it! > >> On Wed, Dec 12, 2018 at 7:25 PM David Jencks <david.a.jen...@gmail.com> >> wrote: >> I don’t quite understand why, how, or where you are setting up symlinks for >> the components. Is there some reason not to put the expected antora >> directory structure inside each components expected maven directory >> structure and assemble them using antora? >> >> e.g. >> >> camel-*/src/main/doc/modules/component/pages/*.adoc > > Yeah I've thought about it, that moves the complexity from having a > single module with ~400 pages of component documentation to having > ~400 individual modules. We could evaluate that approach but on first > hand it seems even more complicated with little to gain. > I didn’t quite realize how many components there are. We’d have to automate keeping the list of components in site.yml synchronized with the actual components. While it would be easy enough to add more symlinks, it might also make it easier to add other resources (pictures, downloads) in using antora conventions. >> I haven’t set up anything nearly this complicated with antora so I could >> easily be missing something obvious :-) > > Neither have I, so keep the feedback coming, I could be missing a lot > of details here :) > >> If this doesn’t work I’d be tempted to try to patch antora to work with >> maven directory structure, do you know if this is impractical? > > I'm not sure that's the way we'd like to go -- it would make us > maintainers of a fork, doing symlinks looks like a pragmatic approach > to me. It's not that much to maintain I think[1]. That is certainly little code to maintain, thanks for pointing it out. I was thinking that supporting maven layout in antora would make antora much more usable directly for java projects so a contribution of such support might be welcome so we wouldn’t have to maintain it. However, I don’t know how open antora devs are to outside contributions. Thanks! David Jencks > > zoran > > [1] > https://github.com/apache/camel/blob/e5523701ca10458cc21f82bc0933f97009f8438f/docs/gulpfile.js#L8-L19 > -- > Zoran Regvart
