I have already addressed most of the errors reported and some of the warnings, I will wait for the next report to be generated and look if we still need to fix. I am going to ask INFRA to enable it and test it and see its scope since I have no idea about but when I was looking at https://lgtm.com/projects/g/apache/incubator-druid/ci/, it looks it only checks the PR content which is a good thing for us.
On Wed, Dec 18, 2019 at 1:45 PM Guillaume Nodet <gno...@apache.org> wrote: > Le mer. 18 déc. 2019 à 09:15, Claus Ibsen <claus.ib...@gmail.com> a écrit > : > > > On Tue, Dec 17, 2019 at 4:17 PM Omar Al-Safi <oals...@apache.org> wrote: > > > > > > Hello folks, > > > > > > Recently, I stumbled across this code analysis tool https://lgtm.com/ > > and > > > is free for open source integration. It looks pretty good based on the > > > analysis results it gave for camel ( > > > https://lgtm.com/projects/g/apache/camel/) (sure some of them it can > be > > > neglected). However, I was wondering, does it make sense to enable it > on > > > PRs? For me personally, it could help to some extent to catch potential > > > bugs that hard to spot by the human eye. > > > > > > > For PRs then can it be limited to only the code from the PR? > > The Camel code base is still massive and I dont want to have some slow > > process for PRs > > > > Right, if that's limited to the code modified by the PR, that could be a > good thing to add the check. > Else, we'd have to wait until the current problems are actually solved > before enabling it on PRs. > > Guillaume > > > > Instead of the tool just runs a general report once a week/month etc > > then we can take a look at it from time to time. > > > > > > > Regards, > > > Omar > > > > > > > > -- > > Claus Ibsen > > ----------------- > > http://davsclaus.com @davsclaus > > Camel in Action 2: https://www.manning.com/ibsen2 > > > > > -- > ------------------------ > Guillaume Nodet >
