Hi David & Cameleers, On Thu, Sep 9, 2021 at 6:57 PM David Jencks <david.a.jen...@gmail.com> wrote: > > Overall I like the gulp file changes, I left one comment.
Thanks for that, good point, I think for future maintenance it's important to have the Gulp build as understandable as possible. Otherwise we'll end up with black magic spaghetti. I'll try to make stuff more apparent or add more comments so it can be understood a bit better. > I discovered another anomaly you might like to investigate: > Is components/camel-disruptor/src/main/docs/disruptor-vm-component.adoc > supposed to exist? It doesn’t appear to have a json file for properties etc, > and it’s rendering in the current site looks slightly odd (with the empty > “Options” section). Most likely the glob for inclusion did not match it, on the `pr/docs-use-symlinks` branch on my fork I just run the build and I did get all the files needed: $ cd docs $ yarn gulp $ find . -name '*disruptor*.*' ./components/modules/ROOT/pages/disruptor-component.adoc ./components/modules/ROOT/pages/disruptor-vm-component.adoc ./components/modules/ROOT/examples/json/disruptor-vm.json ./components/modules/ROOT/examples/json/disruptor.json But another discrepancy I noticed was in the Bindy component, we have one .adoc file and three JSON files: $ find . -name '*bindy*.*' ./components/modules/dataformats/pages/bindy-dataformat.adoc ./components/modules/dataformats/examples/json/bindy-csv.json ./components/modules/dataformats/examples/json/bindy-fixed.json ./components/modules/dataformats/examples/json/bindy-kvp.json That will be a problem, I'll investigate and then create a followup JIRA issue if I can't find a solution. I think this underlines the piecemeal approach I'm trying to take, we'll switch to using symlinks first and then we can change to use the jsonpath macros and JSON files when we see that everything is in place... zoran -- Zoran Regvart
