Dear Vishal, Please find the queries/comments on the design doc.
1. If user is giving any invalid value, default threshold(1000 unique values) value will be considered. What is the consideration behind the default value 1000. 2. There is no option mentioned for the user to alter the table if the ENABLE_LOCAL_DICT and CARBON_LOCALDICT_THRESHOLD values are set. This would also help in compatibility if we want to generate local dictionary for table created in previous carbon versions. 3. There should be validation provided if the user inputs ENABLE_LOCAL_DICT as false and tries to set CARBON_LOCALDICT_THRESHOLD value. 4. Impact of alter table add/drop/change type of column is not mentioned . 5. would complex types also be considered for local dictionary. 6. For any column if dictionary values crosses the threshold (carbon_localdict_threshold), then it will drop dictionary for that column. Could not understand “drop dictionary for that column” 7. For better testability information regarding generation and updation of local dictionary can be logged. Regards Chetan -- Sent from: http://apache-carbondata-dev-mailing-list-archive.1130556.n5.nabble.com/
