I closed 18775 as it did not seem reasonable after discussions here. I have been working on 16565 and have a pull request [1] and an experimental suite to show the differences. [2]
[1] https://github.com/apache/cassandra/pull/2842 [2] https://github.com/Aiven-Labs/compare_oshi_sigar On Wed, Oct 25, 2023 at 2:59 PM Josh McKenzie <jmcken...@apache.org> wrote: > +1 to drop if we're not using. > > On Fri, Oct 20, 2023, at 6:58 PM, Ekaterina Dimitrova wrote: > > +1 on removal the whole lib if we are sure we don’t need it. Nothing > better than some healthy house cleaning > > -1 on partial removals > > On Fri, 20 Oct 2023 at 17:34, David Capwell <dcapw...@apple.com> wrote: > > +1 to drop the whole lib… > > > On Oct 20, 2023, at 7:55 AM, Jeremiah Jordan <jeremiah.jor...@gmail.com> > wrote: > > Agreed. -1 on selectively removing any of the libs. But +1 for removing > the whole thing if it is no longer used. > > -Jeremiah > > On Oct 20, 2023 at 9:28:55 AM, Mick Semb Wever <m...@apache.org> wrote: > > Does anyone see any reason _not_ to do this? > > > > Thanks for bring this to dev@ > > I see reason not to do it, folk do submit patches for other archs despite > us not formally maintaining and testing the code for those archs. Some > examples are PPC64 Big Endian (CASSANDRA-7476), s390x (CASSANDRA-17723), > PPC64 Little Endian (CASSANDRA-7381), sparcv9 (CASSANDRA-6628). Wrote this > on the ticket too. > > +1 for removing sigar altogether (as Brandon points out). > > >
