+1

> On Sep 26, 2025, at 11:07 AM, Yifan Cai <[email protected]> wrote:
> 
> I am also +1 on having the automatic code style check. Plus it ensures the 
> project can compile too. 
> 
> - Yifan
> 
> On Fri, Sep 26, 2025 at 11:04 AM Josh McKenzie <[email protected] 
> <mailto:[email protected]>> wrote:
>> I'm a +1 to it. Easy to overlook, annoying when it bites you.
>> 
>> Makes me think how much more intuitive this would be if we just used github 
>> PR's to merge in commits...
>> 
>> But I don't want to derail this thread with that Pandora's Box. :) So let's 
>> shelve that for another discuss thread.
>> 
>> On Fri, Sep 26, 2025, at 1:48 PM, Mick wrote:
>>> I'd like to propose the following patch: 
>>> https://github.com/apache/cassandra/compare/trunk...thelastpickle:cassandra:mck/gha-lint
>>>  
>>> 
>>> It's a one-liner `check-code.sh` and is light and quick to run at ~6 
>>> minutes.
>>> 
>>> We are supposed to always run `ant check` (what check-code.sh does) before 
>>> merging, but it's understandably an easy thing to forget now and again.  
>>> Such a lightweight gh action will I believe prevent most of the breakages, 
>>> since many of us push our dev branches to gh.  I'm not in favour of making 
>>> it any heavier (that can be a seperate discussion for latter), nor at first 
>>> trying to change/improve our checkstyle rules (that too can be done 
>>> separately). 
>>> 
>>> 
>>> Example result run here: 
>>> https://github.com/thelastpickle/cassandra/actions/runs/17880689988/job/50847932781
>>>  
>>> 
>>> Any objections ?   (a jira ticket will be created)
>>> 
>>> regards,
>>> Mick
>> 

Reply via email to