+1
On 2025/10/18 21:01:08 Abe Ratnofsky wrote: > +1 > > > > > On Oct 18, 2025, at 08:22, Josh McKenzie <[email protected]> wrote: > > > > > > > > > > > +1 > > > > > > > > > > On Fri, Oct 17, 2025, at 5:43 PM, Dinesh Joshi wrote: > > > > >> +1 > > >> > > >> > > > >> > > >> On Fri, Oct 17, 2025 at 2:38 PM Tolbert, Andy > <[[email protected]](mailto:[email protected])> wrote: > > >> > > >>> Hi All, > > >>> > > >>> > > > >>> > > >>> As we need a two more PMC votes, I'd like to extend the vote through > Tuesday Oct 21 at 21:30 UTC (4 days from now). > > >>> > > >>> > > > >>> > > >>> In the meantime i'm working on coming up a Docker build and script with > something adjacent to what was done here for verifying cassandra builds > (<https://github.com/apache/cassandra- > builds/pull/32/files#diff-a636443cd5bfb43c9eddbf4ea4ce8546d63190b9326266245ab0068984fe59c1>), > but for the java driver. Hopefully will be able to get that going this > weekend. I'll work to share something for that soon, and hopefully that can > help us establish some more confidence on our release artifacts! > > >>> > > >>> > > > >>> > > >>> Thanks, > > >>> > > >>> Andy > > >>> > > >>> > > > >>> > > >>> On Thu, Oct 16, 2025 at 8:42 PM Bret McGuire > <[[email protected]](mailto:[email protected])> wrote: > > >>> > > >>>> +1 from me as well for the release overall. > > >>>> > > >>>> > > > >>>> > > >>>> Steps I took to validate are pretty similar to what was on Andy's > list: > > >>>> > > >>>> > > > >>>> > > >>>> * Validated all checksums > > >>>> * Ran a simple test app with dependencies from the staging Maven repo > > >>>> * Ran a DataStax Jenkins job (to confirm all integration tests and DSE > functionality) > > >>>> > > >>>> > > >>>> > > > >>>> > > >>>> For the record: the following might be useful if you're Gradle- > inclined: > > >>>> > > >>>> > > > >>>> > > >>>>> repositories { > > >>>>> > > >>>>> mavenCentral() > > >>>>> > > >>>>> maven { > > >>>>> > > >>>>> url = > uri("<https://repository.apache.org/content/repositories/orgapachecassandra-1423/>") > > >>>>> > > >>>>> } > > >>>>> > > >>>>> } > > >>>> > > >>>> > > > >>>> > > >>>> \- Bret - > > >>>> > > >>>> > > > >>>> > > >>>> On Thu, Oct 16, 2025 at 2:42 PM Bret McGuire > <[[email protected]](mailto:[email protected])> wrote: > > >>>> > > >>>>> +1 to the list Andy put out. That's pretty much the same set of > steps I work through when I validate a given release. > > >>>>> > > >>>>> > > > >>>>> > > >>>>> With respect to the point raised by Abe, he and Andy and I spent some > time talking about this elsewhere. The source tarball is correct; it includes > source for everything. Abe did point out that the distribution tarball in SVN > doesn't have dependent JARs for all subprojects. This is something we can > fix, but it's also probably a good start to a conversation about what role we > want the distribution tarball to play and whether we need it at all anymore. > Further discussion is _definitely_ required there, but the upshot is that no > changes are required for this release; we can move forward with the artifacts > Andy has already uploaded. > > >>>>> > > >>>>> > > > >>>>> > > >>>>> Which in turn reminds me that _I_ need to validate this guy and give > a +1... on to that now! > > >>>>> > > >>>>> > > > >>>>> > > >>>>> \- Bret - > > >>>>> > > >>>>> > > > >>>>> > > >>>>> On Thu, Oct 16, 2025 at 9:42 AM Tolbert, Andy > <[[email protected]](mailto:[email protected])> wrote: > > >>>>> > > >>>>>> Hi Abe, > > >>>>>> > > >>>>>> > > > >>>>>> > > >>>>>> Good catch! I assume you mean the main distribution > (<https://dist.apache.org/repos/dist/dev/cassandra/cassandra-java- > driver/4.19.1/apache-cassandra-java-driver-4.19.1.tar.gz>; which also includes > src zips), it does look like there are some modules missing from the > distribution pom that should probably be included; It's likely that these > modules were never added to the distribution build when they were introduced > and no one has noticed until now. Let me see if I can fix that and make > another go at this. > > >>>>>> > > >>>>>> > > > >>>>>> > > >>>>>> <https://github.com/apache/cassandra-java- > driver/blob/4.x/distribution/pom.xml#L47-L69> > > >>>>>> > > >>>>>> > > > >>>>>> > > >>>>>> Just did a spot check and it looks like the source tar is including > everything since it's just grabbing everything with exception to some > dotfiles. > > >>>>>> > > >>>>>> > > > >>>>>> > > >>>>>> Thanks, > > >>>>>> > > >>>>>> Andy > > >>>>>> > > >>>>>> > > > >>>>>> > > >>>>>> > > > >>>>>> > > >>>>>> On Thu, Oct 16, 2025 at 9:18 AM Abe Ratnofsky > <[[email protected]](mailto:[email protected])> wrote: > > >>>>>> > > >>>>>>> Agree it would be helpful to have a standardized script. > > >>>>>>> > > >>>>>>> > > > >>>>>>> > > >>>>>>> Maybe a noob question, but why do the source artifact distributions > only contain (core, query-builder, mapper-processor, mapper-runtime) and not > (metrics, guava, etc) which do have source files in-tree? > >
