[ 
https://issues.apache.org/cayenne/browse/CAY-911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12863#action_12863
 ] 

Kevin Menard commented on CAY-911:
----------------------------------

All in all, the code looks pretty good.  The second patch could be cleaned up.  
It uses absolute paths rather than relative ones, so I had to modify that.  The 
second patch also contain cruft unrelated to the core issue.  Please make sure 
that non-significant whitespace changes (e.g., trailing whitespace) don't make 
their way into the patch.  Same deal with the Eclipse project files, such as 
.classpath.

Unfortunately, I can't apply the patch to trunk quite yet because there may be 
a licensing issue.  The patch contains code taken from the link mentioned in 
the issue body.  All code contributions must be ASLv2 compatible.  This code is 
listed as being released into the public domain, which I understand to be a 
forfeiture of copyright and thus no license at all.  So, before we commit, I'd 
like get that issue squared away.



> CM Usability: JComboBox Autocompletion
> --------------------------------------
>
>                 Key: CAY-911
>                 URL: https://issues.apache.org/cayenne/browse/CAY-911
>             Project: Cayenne
>          Issue Type: New Feature
>          Components: CayenneModeler GUI
>            Reporter: Thomas Bernhard
>            Assignee: Kevin Menard
>         Attachments: patch-2008-05-11.txt, patch-CAY-911.txt
>
>
> Please use JComBox with autocompletion in CM at least in places that are very 
> repetitive like selecting Field Types.
> It is very simple to implement it and there are several extremly well 
> documented examples how to do it. E.g.:
> http://www.orbital-computer.de/JComboBox/

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to