Thanks for thevaluable ideas which leads me to do my job properly and I got a e-mail from Google Open Source Programs Team and according to it I have passed from the midterm evaluation. And Special thank should goes to Ksenia. Looking forward to work with the team for next updates.
On Mon, Jul 11, 2011 at 11:54 AM, Andrus Adamchik <[email protected]>wrote: > I have no problem if we change DefaultActionManager etc. on the Cayenne end > to be easily extendable class. CayenneModeler configuration of internal > classes has lots of shortcuts, as it never assumed other apps using or > extending this code. Now it is time to evolve it. > > Andrus > > On Jul 10, 2011, at 1:12 PM, Ksenia Khailenko wrote: > > > Andrus, look at this one, please. We have the DefaultActionManager with > > final property which we want to override. It is possible to create an > > another implementation of ActionManager, but in fact in this case, we > > duplicate a lot of code... > > > > 2011/7/2 Eshan Sudharaka <[email protected]> > > > >> Yes. It is possible. I have attached patch files with this. For this > patch > >> I had to add default constructors to following classes. > >> > >> CayenneController.java > >> CayenneModelerController.java > >> > >> trunk.patch includes this modification (Actualy no need to apply > >> trunk.patch just add default constructors to those clases) > >> > >> Second patch includes the modifications included in this thread. > >> > >> > >> On Fri, Jul 1, 2011 at 8:59 PM, Ksenia Khailenko < > [email protected]>wrote: > >> > >>> May be it would be better not to extend from DefaultActionManager, but > >>> implement it's interface? Is it possible? > >>> > >>> 2011/7/1 Eshan Sudharaka <[email protected]> > >>> > >>>> Thanks. I got it. I have another problem in implementing plugin > actions > >>>> classes. We can register external Actions to actionMap in > >>>> DefaultActionManager class. So I registered PlugingProject class and > add > >>>> that class in to file menu of CayenneModelerFrame and run my plugin. > >>> Then > >>>> it > >>>> seems project close action is menu item is disabled .I think I need > add > >>>> PluginProjectAction class following in DefaultActionManager class. > >>>> > >>>> static final Collection<String> PROJECT_ACTIONS = Arrays.asList( > >>>> RevertAction.class.getName(), > >>>> ProjectAction.class.getName(), > >>>> ValidateAction.class.getName(), > >>>> SaveAsAction.class.getName(), > >>>> FindAction.class.getName()); > >>>> > >>>> Here I should add my PluginProjectAction class. I have extended > >>>> PluginActionManager from DefaultActionManager class. Since this is a > >>> static > >>>> this list is not inherited to child class and also we can not add any > >>> thing > >>>> since it is final. How to overcome this issue ? We can do this by > >>> modifying > >>>> parent class ( DefaultActionManager class ) and I am not sure whether > it > >>> is > >>>> a good approach or not. Now I am working on this. > >>>> > >>>> Thanks. > >>>> > >>>> On Thu, Jun 30, 2011 at 7:04 PM, Ksenia Khailenko < > >>> [email protected] > >>>>> wrote: > >>>> > >>>>>>>>>> > >>>>> 1:07 > >>>>> Eshan Sudharaka > >>>>> Hi , what is the reason to do setEnable(false ) for some items in > >>> file > >>>>> menu > >>>>> in cayenne modeler in your plugin ? > >>>>> I dint get the point > >>>>>>>>>>>> > >>>>> Eshan means this one: > >>>>> > >>>>> if (NewProjectAction.getActionName().equals(name) > >>>>> + || > >>>> OpenProjectAction.getActionName().equals(name) > >>>>> + || > ProjectAction.getActionName().equals(name) > >>>>> + || "Recent Projects".equals(name)) { > >>>>> + item.setEnabled(false); > >>>>> + } > >>>>> All these actions perform manipulations with some another projects, > >>> but > >>>> we > >>>>> are dealing with the selected project from Eclipse, so, it was > >>> considered > >>>>> then that the switching between projects is undesirable when working > >>> with > >>>>> plugin - it may happen that we don't have the correspondent project > in > >>>>> Eclipse, and on change will try to update it... > >>>>> > >>>>> But I think we can enable the "NewProjectAction" for example, to > >>> create > >>>> the > >>>>> cayenne project by the plugin....or we can just leave these buttons > >>> for > >>>> now > >>>>> > >>>>> 2011/6/28 Andrus Adamchik <[email protected]> > >>>>> > >>>>>> Sounds good. > >>>>>> > >>>>>> We might still want to change the naming convention for consistency > >>>> down > >>>>>> the road, but good to hear there's no urgency. > >>>>>> > >>>>>> Andrus > >>>>>> > >>>>>> On Jun 28, 2011, at 2:16 PM, Eshan Sudharaka wrote: > >>>>>> > >>>>>>> Hi , > >>>>>>> I am sorry. I found a way to check the content of the XML files > >>>>>> (currently > >>>>>>> root element) and if it is cayenne project file then load cayenne > >>>> icon > >>>>> in > >>>>>>> eclipse. So no need of changing file naming conventions. > >>>>>>> > >>>>>>> On Sun, Jun 26, 2011 at 8:34 PM, Andrus Adamchik < > >>>>> [email protected] > >>>>>>> wrote: > >>>>>>> > >>>>>>>> > >>>>>>>> On Jun 26, 2011, at 5:45 PM, Andrus Adamchik wrote: > >>>>>>>> > >>>>>>>>> However... nothing prevents us from changing the naming > >>> convention > >>>>>> again. > >>>>>>>> After all 3.1 is not final yet (not even Beta). We might as well > >>>> adopt > >>>>>>>> another "double extension": > >>>>>>>>> > >>>>>>>>> Main project file: xyz.cayenne.xml > >>>>>>>>> DataMap file: xyz.map.xml > >>>>>>>>> > >>>>>>>>> This will ensure both types of files follow a similar > >>> convention, > >>>> and > >>>>>>>> make them Eclipse-friendly. > >>>>>>>> > >>>>>>>> Also the beauty of Cayenne 3.1 is that the name of the project > >>> file > >>>> is > >>>>>>>> specified explicitly when the runtime is started, so the file can > >>>>> really > >>>>>> be > >>>>>>>> called anything (doesn't even have to have .xml extension). So > >>> the > >>>>> focus > >>>>>> of > >>>>>>>> this discussion is the tools (CayenneModeler, Eclipse, etc..), > >>> not > >>>> the > >>>>>>>> runtime. > >>>>>>>> > >>>>>>>> Andrus > >>>>>>>> > >>>>>>>> > >>>>>>> > >>>>>>> > >>>>>>> -- > >>>>>>> *~Thanks & Regards~* > >>>>>>> *** > >>>>>>> * > >>>>>>> P.A.Eshan Sudharaka > >>>>>>> Dept of Computer Science and Engineering > >>>>>>> University of Moratuwa > >>>>>>> Sri Lanka > >>>>>>> http://esudharaka.blogspot.com/ > >>>>>> > >>>>>> > >>>>> > >>>>> > >>>>> -- > >>>>> Regards, Ksenia Khailenko > >>>>> > >>>> > >>>> > >>>> > >>>> -- > >>>> *~Thanks & Regards~* > >>>> *** > >>>> * > >>>> P.A.Eshan Sudharaka > >>>> Dept of Computer Science and Engineering > >>>> University of Moratuwa > >>>> Sri Lanka > >>>> http://esudharaka.blogspot.com/ > >>>> > >>> > >>> > >>> > >>> -- > >>> Regards, Ksenia Khailenko > >>> > >> > >> > >> > >> -- > >> *~Thanks & Regards~* > >> *** > >> * > >> P.A.Eshan Sudharaka > >> Dept of Computer Science and Engineering > >> University of Moratuwa > >> Sri Lanka > >> http://esudharaka.blogspot.com/ > >> > >> > > > > > > -- > > Regards, Ksenia Khailenko > > -- *~Thanks & Regards~* *** * P.A.Eshan Sudharaka Dept of Computer Science and Engineering University of Moratuwa Sri Lanka http://esudharaka.blogspot.com/
