+1 (binding)

I checked
- git commit hash is correct.
- links are valid.
- signatures are good.
```
gpg --import KEYS
gpg --verify apache-celeborn-0.4.1-bin.tgz.asc
gpg --verify apache-celeborn-0.4.1-source.tgz.asc
```
- checksums are good.
```
sha512sum --check apache-celeborn-0.4.1-bin.tgz.sha512
sha512sum --check apache-celeborn-0.4.1-source.tgz.sha512
```
- LICENSE looks good.
- NOTICE looks good.
- build success from source code (macOS).
```
./build/make-distribution.sh --sbt-enabled --release
```

I also tested performance, no regression:
1T TPCDS, 0.4.0 vs. 0.4.1: 2136s vs. 2127s
734G pure shuffle, 0.4.0 vs. 0.4.1: 10.3min vs. 10.3min

Regards,
Keyong Zhou

Cheng Pan <pan3...@gmail.com> 于2024年5月21日周二 14:16写道:

> +1
>
> I have rolled out this version to a small cluster for several days,
> everything goes well so far.
>
> I checked the
> org.apache.celeborn:celeborn-client-spark-3-shaded_2.12:0.4.1, it does not
> pull transitive deps now. While there might be some issues with the
> relocation of Guava classes, specifically, package
> `com.google.thirdparty.publicsuffix` still be there.
>
> Thanks,
> Cheng Pan
>
>
> > On May 14, 2024, at 12:13, Nicholas Jiang <nicholasji...@apache.org>
> wrote:
> >
> > Hi Celeborn community,
> >
> > This is a call for a vote to release Apache Celeborn
> >
> > 0.4.1-rc1
> >
> >
> > The git tag to be voted upon:
> >
> > https://github.com/apache/celeborn/releases/tag/v0.4.1-rc1
> >
> > The git commit hash:
> > 641180142c5ef36430a6afcd702c9487a6007458 source and binary artifacts can
> be
> > found at:
> >
> > https://dist.apache.org/repos/dist/dev/celeborn/v0.4.1-rc1
> >
> > The staging repo:
> >
> >
> https://repository.apache.org/content/repositories/orgapacheceleborn-1055
> >
> >
> > Fingerprint of the PGP key release artifacts are signed with:
> > D73CADC1DAB63BD3C770BB6D9476842D24B7C885
> >
> > My public key to verify signatures can be found in:
> >
> > https://dist.apache.org/repos/dist/release/celeborn/KEYS
> >
> > The vote will be open for at least 72 hours or until the necessary
> > number of votes are reached.
> >
> > Please vote accordingly:
> >
> > [ ] +1 approve
> > [ ] +0 no opinion
> > [ ] -1 disapprove (and the reason)
> >
> > Steps to validate the release:
> >
> > https://www.apache.org/info/verification.html
> >
> > * Download links, checksums and PGP signatures are valid.
> > * Source code distributions have correct names matching the current
> release.
> > * LICENSE and NOTICE files are correct.
> > * All files have license headers if necessary.
> > * No unlicensed compiled archives bundled in source archive.
> > * The source tarball matches the git tag.
> > * Build from source is successful.
> >
> > Regards,
> > Nicholas Jiang
>
>
>

Reply via email to