Thanks for this proposal. Refactoring the transport proto file will prove more advantageous than amalgamating the transport and resource proto files. I concur that the primary objective of CIP-16 should be refocused on enhancing the readability and extensibility of Celeborn's codebase.
This will need some effort, I will offer some help. Thanks, Ethan Feng rexxiong <[email protected]> 于2024年12月19日周四 16:08写道： > > Thanks for the proposal. > > I completely agree that the resource.proto protocol should be upgraded to > proto3 and should share some structures from TransportMessages.proto. > > However, I find that TransportMessages.proto is currently too bulky and > contains protocols for the client, worker, and master all in one. > Could we separate TransportMessages into three modules: Common, Client, and > Server? This would allow > for shared structures while also making it clearer to know the impact area > when modifying the protocols. > > > Thanks, > Jiashu Xiong > > he zhao <[email protected]> 于2024年12月17日周二 16:57写道： > > > Hi all, > > > > I would like to start a discussion on CIP-16: Merge resource proto and > > transport proto[1]. > > > > Looking forward to everyone's feedback and suggestions. Thanks in advance. > > > > [1] > > https://docs.google.com/document/d/1_sgDfyizkvQ7PFryIH_AbD320fxGvFcLCb_EZFNs7Nc/edit?usp=sharing > > > > Regards, > > He > >
