Hi He, Thanks for the proposal. It seems that the proposal involves refactoring TransportMessages.proto, and the current design mainly focuses on the compatibility problem in Java code. Yet currently the CppClient proposed in CIP-14[1] is under active development and already has dependency on Java side's transport proto file[2]. To make the message compatible, the CppClient has to use the same proto definition as well as the same protobuf version to Java side.
Although CppClient is still on its early stage, I think maybe give a look on how the CppClient side should adapt to the refactored proto layout would make the proposal more complete. [1] https://cwiki.apache.org/confluence/display/CELEBORN/CIP-14+Support+CppClient+in+Celeborn [2] https://github.com/apache/celeborn/commit/80ebb19836f886451b0115e8b0eaa53dac3d94da Regards, Jiaming he zhao <[email protected]> 于2024年12月17日周二 16:57写道: > > Hi all, > > I would like to start a discussion on CIP-16: Merge resource proto and > transport proto[1]. > > Looking forward to everyone's feedback and suggestions. Thanks in advance. > > [1] > https://docs.google.com/document/d/1_sgDfyizkvQ7PFryIH_AbD320fxGvFcLCb_EZFNs7Nc/edit?usp=sharing > > Regards, > He
