pnoltes commented on code in PR #388:
URL: https://github.com/apache/celix/pull/388#discussion_r1018290941


##########
examples/celix-examples/dm_example_cxx/CMakeLists.txt:
##########
@@ -22,9 +22,10 @@ add_subdirectory(phase2)
 add_subdirectory(phase3)
 add_subdirectory(phase3_locking)
 
-add_celix_container("dm_example_cxx"
+add_celix_container(dm_example_cxx
+    FAT
     GROUP cxx_examples
-    BUNDLES
+    EMBEDDED_BUNDLES

Review Comment:
   Yes, because there are enough examples using BUNDLES, IMO updating 1 to 
EMBEDDED_BUNDLES is enough and this does not increase the nr of celix 
containers to build.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to