pnoltes commented on code in PR #388:
URL: https://github.com/apache/celix/pull/388#discussion_r1018292333
##########
cmake/cmake_celix/BundlePackaging.cmake:
##########
@@ -497,19 +519,25 @@ function(bundle_import_libs)
celix_bundle_import_libs(${ARGN})
endfunction()
+#[[
+Adds a import lib to the Celix bundle.
+
+NOTE: Currently importing lib support is Celix is not complete and still
experimental.
+]]
function(celix_bundle_import_libs)
#0 is bundle TARGET
#2..n is import libs
list(GET ARGN 0 BUNDLE)
list(REMOVE_AT ARGN 0)
- #check if arg 0 is corrent
+ #check if arg 0 is correct
check_bundle(${BUNDLE})
get_target_property(LIBS ${BUNDLE} "BUNDLE_IMPORT_LIBS")
set(LIBS )
foreach(LIB IN ITEMS ${ARGN})
+ message(WARNING "Bundle with import libs in Celix is not complete and
still experimental.")
Review Comment:
Correct, but I would prefer an warning because imported libs from an other
bundle is not really supported.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
