PengZheng commented on code in PR #476:
URL: https://github.com/apache/celix/pull/476#discussion_r1116885519
##########
libs/framework/include/module.h:
##########
@@ -42,9 +43,9 @@ typedef struct module *module_pt;
extern "C" {
#endif
-module_pt module_create(manifest_pt headerMap, const char *moduleId,
celix_bundle_t *bundle);
+module_pt module_create(manifest_pt headerMap, const char *moduleId,
celix_framework_t* fw, celix_bundle_t *bundle);
Review Comment:
Why we need this extra fw if bundle already contains what we need?
I still need to understand the relationship between `module` and `bundle`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
