PengZheng commented on code in PR #476:
URL: https://github.com/apache/celix/pull/476#discussion_r1117885783
##########
libs/framework/src/celix_launcher.c:
##########
@@ -62,107 +76,93 @@ int celixLauncher_launchAndWaitForShutdown(int argc, char
*argv[], celix_propert
opt = argv[1];
}
- char *config_file = NULL;
+ char* configFile = NULL;
bool showProps = false;
bool showEmbeddedBundles = false;
+ bool createCache = false;
for (int i = 1; i < argc; ++i) {
opt = argv[i];
// Check whether the user wants some help...
if (strncmp("-?", opt, strlen("-?")) == 0 || strncmp("-h", opt,
strlen("-h")) == 0 || strncmp("--help", opt, strlen("--help")) == 0) {
Review Comment:
I'd prefer `sizeof("-?")` rather than `strlen("-?")`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
