PengZheng commented on code in PR #476: URL: https://github.com/apache/celix/pull/476#discussion_r1118011919
########## libs/framework/include/celix_bundle_context.h: ########## @@ -1311,7 +1311,7 @@ void celix_bundleContext_vlog( * @param defaultValue The default value if the property is not found. * @return The property value or the default value if the property is not found. */ -const char* celix_bundleContext_getProperty(celix_bundle_context_t *ctx, const char *key, const char *defaultVal); +const char* celix_bundleContext_getProperty(celix_bundle_context_t *ctx, const char* key, const char* defaultVal); Review Comment: `const char* key` rather than `const char *key`, `const celix_bundle_context_t *ctx` rather than `const celix_bundle_context_t* ctx`. Is there any coding convention involved? I tried my best to following existing convention in current code base. If you set the Celix coding convention in stone, it will be easier for us to follow. PS: So far as I know, Zhenbao is preparing a large PR of unified service discovery based on mDNS. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
