PengZheng commented on code in PR #476:
URL: https://github.com/apache/celix/pull/476#discussion_r1117912235
##########
libs/framework/src/celix_launcher.c:
##########
@@ -220,7 +231,7 @@ static void show_properties(celix_properties_t
*embeddedProps, const char *confi
printf("\n");
//combined result
- combine_properties(embeddedProps, runtimeProps);
+ celixLauncher_combineProperties(embeddedProps, runtimeProps);
Review Comment:
Could we remove it?
We already have `keys`. There is no need to combine them into
`embeddedProps`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
