PengZheng commented on code in PR #815:
URL: https://github.com/apache/celix/pull/815#discussion_r2724881748
##########
libs/utils/CMakeLists.txt:
##########
@@ -18,7 +18,13 @@
celix_subproject(UTILS "Option to enable building the Utilities library" ON)
if (UTILS)
find_package(libzip REQUIRED)
- find_package(jansson REQUIRED) #TODO add jansson dep info to build (conan)
and documentation info
+ find_package(jansson REQUIRED)
+ find_package(libuv REQUIRED)
+
+ if (NOT TARGET libuv::uv AND TARGET uv)
+ #Note: conan libuv package 1.49.2 defines uv target, but 1.51.0
defines libuv::uv target
Review Comment:
Using latest conan 1.x is OK, thus this hack can be removed.
Let update our conan 1.x all to the latest.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
