PengZheng commented on code in PR #815:
URL: https://github.com/apache/celix/pull/815#discussion_r2730498059
##########
libs/utils/CMakeLists.txt:
##########
@@ -18,7 +18,13 @@
celix_subproject(UTILS "Option to enable building the Utilities library" ON)
if (UTILS)
find_package(libzip REQUIRED)
- find_package(jansson REQUIRED) #TODO add jansson dep info to build (conan)
and documentation info
+ find_package(jansson REQUIRED)
+ find_package(libuv REQUIRED)
+
+ if (NOT TARGET libuv::uv AND TARGET uv)
+ #Note: conan libuv package 1.49.2 defines uv target, but 1.51.0
defines libuv::uv target
Review Comment:
Running conan1 gives the following notice:
```
WARN: **************************************************
WARN: *** Conan 1 is legacy and on a deprecation path **
WARN: *********** Please upgrade to Conan 2 ************
WARN: **************************************************
```
I think it's time to get rid of Conan 1.x.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
