[
https://issues.apache.org/jira/browse/CLIMATE-634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14540219#comment-14540219
]
ASF GitHub Bot commented on CLIMATE-634:
----------------------------------------
Github user kwhitehall commented on the pull request:
https://github.com/apache/climate/pull/196#issuecomment-101349340
@chrismattmann I've added a unittest as suggested. (I can clean it up
later if we decide to keep it The purpose is to illustrate the shape of the
datasets and which aspects are being captured. I can provide an example of it
being used but the example provided by @huikyole is basically it. In that
example under @huikyole CLIMATE-634tix, if you use
utils.calc_climatology_season you will see the original bug indicated in this
tix, and you'll observe that it the functionality works (at least for JJA, and
this change will allow it work for DJF).
@huikyole I had a look at PR#197, I see you are trying to capture the
DS.times showing the timeslicing that occurred (which isn't functionality
available now). I agree this is useful, and should be captured. I have included
in this unittest capturing the timeseries. That said, a discussion is also
needed in my opinion wrt to what happens when the seasonal mean captured as
oppose to the time series of the seasons i.e. what does one put in DS.times
when the season is averaged over the years e.g. do we use
datetime(1,startmth,day), datetime(1,endmth,day)? See
http://www.cgd.ucar.edu/cms/eaton/netcdf/CF-20010629.htm#climatology
> fix calc_climatology_monthly
> -----------------------------
>
> Key: CLIMATE-634
> URL: https://issues.apache.org/jira/browse/CLIMATE-634
> Project: Apache Open Climate Workbench
> Issue Type: Bug
> Reporter: Kim Whitehall
> Assignee: Kim Whitehall
>
> Bug if start month > end mth causes calc_climatology_season to fail
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
