[ 
https://issues.apache.org/jira/browse/CLIMATE-634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14540488#comment-14540488
 ] 

ASF GitHub Bot commented on CLIMATE-634:
----------------------------------------

Github user MJJoyce commented on the pull request:

    https://github.com/apache/climate/pull/197#issuecomment-101388428
  
    The problem with the movement of calc_climatology_season in the format it 
was moved in is that it doesn't follow the dataset processor conventions. A 
dataset_processor function takes an OCW Dataset and some parameters and returns 
a modified OCW dataset. If you want a function that takes an OCW Dataset and 
returns some other information then that should be in utils.
    
    Also I'm not seeing how this slide relates to the other comments in this 
thread, but I think I'm missing something?


> fix calc_climatology_monthly 
> -----------------------------
>
>                 Key: CLIMATE-634
>                 URL: https://issues.apache.org/jira/browse/CLIMATE-634
>             Project: Apache Open Climate Workbench
>          Issue Type: Bug
>            Reporter: Kim Whitehall
>            Assignee: Kim Whitehall
>
> Bug if start month > end mth causes calc_climatology_season to fail



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to