[ https://issues.apache.org/jira/browse/CLIMATE-649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14654452#comment-14654452 ]
ASF GitHub Bot commented on CLIMATE-649: ---------------------------------------- Github user MBoustani commented on a diff in the pull request: https://github.com/apache/climate/pull/220#discussion_r36249157 --- Diff: ocw-cli/cli_app.py --- @@ -599,123 +608,56 @@ def run_screen(model_datasets, models_info, observations_info, screen.addstr(6, 4, "Spatially regridding...") screen.refresh() - new_lats = np.arange(overlap_min_lat, overlap_max_lat, spatial_grid_setting) - new_lons = np.arange(overlap_min_lon, overlap_max_lon, spatial_grid_setting) - for i in range(len(obs_dataset)): - obs_dataset[i] = dsp.spatial_regrid(obs_dataset[i], new_lats, new_lons) + if spatial_grid_option == 'Observation': --- End diff -- No need for this "if" condition. Checkout line 1241 on file https://github.com/apache/climate/blob/master/ocw-cli/cli_app.py > Update CLI > ---------- > > Key: CLIMATE-649 > URL: https://issues.apache.org/jira/browse/CLIMATE-649 > Project: Apache Open Climate Workbench > Issue Type: Improvement > Components: command line interface > Affects Versions: 1.0.0 > Reporter: Huikyo Lee > Assignee: Huikyo Lee > Priority: Critical > Fix For: 0.5 > > > Updates include following changes. > - It is assumed that there is only one observation data > - time period does not have to be a multiple of 12. > - regridding process needs to be corrected. Only two regridding options > ('Observation' and 'User specified') are available in this new version. > - For calculation of metrics and drawing a plot use external package, CLI > calls example_package.py -- This message was sent by Atlassian JIRA (v6.3.4#6332)