[ 
https://issues.apache.org/jira/browse/CLIMATE-649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14654907#comment-14654907
 ] 

ASF GitHub Bot commented on CLIMATE-649:
----------------------------------------

Github user huikyole commented on a diff in the pull request:

    https://github.com/apache/climate/pull/220#discussion_r36273612
  
    --- Diff: ocw-cli/cli_app.py ---
    @@ -115,7 +119,7 @@ def load_local_model_screen(header):
                        note = "WARNING: Model file cannot be added."
                   elif answer == "1":
                        model_dataset = load_file(model_path, variable_name)
    -                   model_datasets.append(model_dataset)
    +                   
model_datasets.append(dsp.normalize_dataset_datetimes(model_dataset, 
model_dataset.temporal_resolution()))
    --- End diff --
    
    dsp.normalize is important to make every monthly data's day become 1. 
Otherwise, values of day range from 1 and 30. In many model datasets, day=15 
for monthly mean data. This makes users to set up start and end date without 
confusion. For example, the maximum overlap period is from 1980/01/15 and 
2000/12/15. What if a user choose 1980/01/01 and 2000/12/31 as start and end 
dates respectively? 


> Update CLI
> ----------
>
>                 Key: CLIMATE-649
>                 URL: https://issues.apache.org/jira/browse/CLIMATE-649
>             Project: Apache Open Climate Workbench
>          Issue Type: Improvement
>          Components: command line interface
>    Affects Versions: 1.0.0
>            Reporter: Huikyo Lee
>            Assignee: Huikyo Lee
>            Priority: Critical
>             Fix For: 0.5
>
>
> Updates include following changes.
> - It is assumed that there is only one observation data
> - time period does not have to be a multiple of 12.
> - regridding process needs to be corrected. Only two regridding options 
> ('Observation' and 'User specified') are available in this new version.
> - For calculation of metrics and drawing a plot use external package, CLI 
> calls example_package.py



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to