> On Aug. 24, 2013, 5:47 p.m., Michael Joyce wrote: > > http://svn.apache.org/repos/asf/incubator/climate/trunk/ocw/dataset.py, > > lines 173-180 > > <https://reviews.apache.org/r/13738/diff/1/?file=343842#file343842line173> > > > > Have you checked that the formatting of this string looks proper when > > run? I just ran a similar test case and I ended up with a tab in front of > > the second line. Not sure if that's the look we were going for or not with > > this.
Mike, I just tested this out and you are correct the indentation on the second line comes out in the final error message. I have de-indented the lines below and the tests pass, and the code lint's better since all the other lines drop below 80 chars. It isn't pretty in the code, but the user will get a much better error message telling them what went wrong. - Cameron ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13738/#review25505 ----------------------------------------------------------- On Aug. 22, 2013, 3:15 p.m., Cameron Goodale wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13738/ > ----------------------------------------------------------- > > (Updated Aug. 22, 2013, 3:15 p.m.) > > > Review request for Apache Open Climate and Michael Joyce. > > > Bugs: CLIMATE-274 > https://issues.apache.org/jira/browse/CLIMATE-274 > > > Repository: climate > > > Description > ------- > > I created 5 different ValueError exception error messages for each different > check we perform when a Dataset object is initialized. > > > Diffs > ----- > > http://svn.apache.org/repos/asf/incubator/climate/trunk/ocw/dataset.py > 1516193 > > Diff: https://reviews.apache.org/r/13738/diff/ > > > Testing > ------- > > I re-ran test_dataset.py and all 23 tests pass. > > > Thanks, > > Cameron Goodale > >
